Tay Ray Chuan <rctay89@xxxxxxxxx> writes:
> *spaces used as indentation have been replaced by tabs instead.
>
> *'if' and 'while' conditionals with a single line have had their curly
> braces removed.
>
We need to apply a style fix to your commit messages first.
Using '*' without any space as the enumeration bullet makes the message
harder to read. Please don't. Also we prefer to give orders to the
person who applies the patch (i.e. "do _this_, so that the result becomes
better in _this_ and _that_ way"), instead of saying "I've done this and
that".
- Use tabs to indent, instead of spaces.
- Do not use curly-braces around a single statement body in
if/while statement;
- Do not start multi-line comment with description on the first
line after "/*", i.e.
/*
* We prefer this over...
*/
/* comments like
* this (notice the first line)
*/
I personally do not necessarily agree with the first "clean-up", but as
long as the style is internally consistent within the file that's Ok.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html