On Sun, May 24, 2009 at 12:43:30PM -0400, Jeff King wrote:
> > +++ b/t/t5500-fetch-pack.sh
> > @@ -97,7 +97,7 @@ pull_to_client () {
> > (
> > mkdir client &&
> > cd client &&
> > - git init 2>> log2.txt &&
> > + git init 2>> log2.txt > /dev/null &&
> > git config transfer.unpacklimit 0
> > )
>
> Why not:
>
> test_expect_success 'setup client repo' '
> mkdir client &&
> (cd client &&
> git init 2>>log2.txt &&
> git config transfer.unpacklimit 0
> )
> '
Actually, taking a closer look at the script, I think you could probably
ditch the '2>>log2.txt' bit entirely. The log file is never read and
appears to be completely for debugging. Putting the code into the test
harness means that output will respect --verbose properly, which means a
separate log is unnecessary.
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html