On Fri, May 22, 2009 at 05:30:31PM +1000, Nguyen Thai Ngoc Duy wrote: > 2009/5/22 Johannes Sixt <j.sixt@xxxxxxxxxxxxx>: > > Nguyễn Thái Ngọc Duy schrieb: > >> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> > > > > Is it possible for you to test this series on Windows? Many rebase tests > > fail, but I haven't investigated why. > > I'll try it this weekend. This patch makes t3*rebase*.sh pass for me except t3412 (more exactly t3412.8). That test failed even with git-rebase.sh. Hmm... Anyway could you try again to see what tests still fail? --<-- diff --git a/builtin-rebase.c b/builtin-rebase.c index 2acea59..5582f1d 100644 --- a/builtin-rebase.c +++ b/builtin-rebase.c @@ -56,7 +56,8 @@ static int rebase_config(const char *var, const char *value, void *data) ((struct rebase_opt*)data)->flags |= REBASE_STAT; return 0; } - return 0; + + return git_default_config(var, value, data); } /* utility functions */ @@ -504,7 +505,7 @@ static void run_interactive(int argc, const char **argv) ret = run_command(&cp); if (IS_RUN_COMMAND_ERR(ret)) die("Failed to run git rebase--interactive"); - exit(ret); + exit(-ret); } /* from diff.c */ --<-- -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html