On Friday, 22. May 2009 10:02:58 Jeff King wrote: > On Fri, May 22, 2009 at 03:56:20AM -0400, Jeff King wrote: > > Yeah, it is fine because it just passes the result to prep_temp_blob, > > which respects the length. I don't know if it is worth making it more > > safe (arguably it should just be using strbuf_readlink anyway, but that > > does introduce an extra malloc). > > And here is the strbuf_readlink version, which actually does make the > source shorter and easier to read. Good work! Patch looks fine to me. Guess you can't even benchmark the "extra" malloc ;-) Have a nice weekend, Thomas -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html