Jeff King wrote: > Having just fixed a segfault in the GIT_TRACE code caused by a > non-terminated argv generated by the alias code, I think I would prefer > that we just consistently do the NULL-termination. You are otherwise > creating a maintenance pitfall when somebody later passes the value to > unsuspecting code. Speaking of that, there is also one piece of code in diff.c that doesn't do NULL-termination after a readlink() call (which never NULL-terminates). The current use is 100% fine, though the same maintenance argument might apply here, too. Wondering why the buffer is allocated as PATH_MAX +1. Hmm. Thomas -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html