Re: [PATCH v2] Extend sample pre-commit hook to check for non ascii filenames

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 15, 2009 at 12:52:41PM +0200, Martin Langhoff wrote:
> On Thu, May 14, 2009 at 7:59 PM, Heiko Voigt <hvoigt@xxxxxxxxxx> wrote:
> > At the moment non-ascii encodings of filenames are not portably converted
> > between different filesystems by git. This will most likely change in the
> > future but to allow repositories to be portable among different file/operating
> > systems this check is enabled by default.
> 
> Nice!
> 
>  - It'd be a good idea to add to the mix a check for filenames that
> are equivalent in case-insensitive FSs.

I agree, but that will be an extension in another patch. BTW, if anyone
has a good idea how to efficiently do that kind of check in a hook I'd
cook up a patch on top of this.

>  - Should all of this be a general "portablefilenames" setting?

Well, if you can specify what general portable filenames would have as
properties.

Questions like:

 * What is the portable maximum path length?
 * How long may a filename be (DOS 8.3 ?)
 * Are windows keywords (PRN, ...) allowed?
 * ...

So I think this should be on a per property basis providing sensible
defaults to support the most standard case.

cheers Heiko
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]