Ammon Riley <ammon.riley@xxxxxxxxx> writes: > On Sat, May 16, 2009 at 12:56 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: >> Ammon Riley <ammon.riley@xxxxxxxxx> writes: >> >>> There was an xmalloc() for path, but I didn't see a corresponding free(). >>> Does it happen somewhere else that I'm not expecting? >> >> It implicitly happens in exit() in git.c:handle_internal_command() >> after cmd_init_db() returns the control to it. > > Ah. Naturally. :) > > So if I were to write a long-lived application (such as a custom UI) that > links to libgit, and bypasses those functions to call init_db() (and other > functions) directly, all those implicit free-on-exit() turn into memory > leaks. Correct, and there are other much larger issues to worry about. That's why there is a separate libgit2 effort in progress. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html