Re: [PATCH 3/3] improved validation of entry type in mktree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jakub Narebski <jnareb <at> gmail.com> writes:

> 
> Josh Micich wrote:
> 
> > Furthermore even with '--missing', a tree entry like this should be 
rejected:
> > 160000 commit e69de29bb2d1d6434b8b29ae775ad8c2e48c5391  foo
> 
> But with submodules you might not _have_ e69de29b in object database
> to check its type!

The code already accounted for that case.  If the tree entry is a GIT_LINK 
("160000 commit ..."), it is not mandatory for the referenced object to exist 
locally.  But if the object _does_ exist, the type should match.  I guess I 
should have prefixed that example with "assuming object e69de29b (empty tree) 
is present in the local database".



--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]