Re: git-tag bug? confusing git fast-export with double tag objects

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2009/5/15 Johannes Sixt <j.sixt@xxxxxxxxxxxxx>:
> Jakub Narebski schrieb:
>> "Matthias Andree" <matthias.andree@xxxxxx> writes:
>>>      commit <-- signed-by-- NIL (removed) <--signed-by-- tag1.
>>
>> THIS IS A FEATURE, NOT A BUG.
>
> Please stop it. Everone agrees about this.
>
> Matthias only wants a patch like below. Matthias, if you are serious about
> it, please pick this up and turn it into a proper submission. I don't care
> enough.
>
...
> +       if ((tag_object = (struct tag *)parse_object(object)) &&
> +           tag_object->object.type == OBJ_TAG &&
> +           tag_object->tag &&
> +           !strcmp(tag_object->tag, tag)) {
> +               error("A tag cannot tag itself. If you meant to tag the commit");

If it ever turned into submission, I'll always patch this out. It is stupid.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]