On Thu, May 14, 2009 at 12:22:03AM +0300, Felipe Contreras wrote: > In order to do that I had to change prettify_ref to prettify_refname because > add_ref_decoration doesn't have the ref object. Thanks, this 1/3 looks fine to me. But: > Felipe Contreras (3): > Change prettify_ref to prettify_refname > Prettify log decorations even more > Fix test for new log decorate Shouldn't 2/3 and 3/3 just be squashed together? It looks like 3/3 fixes tests broken in 2/3, so you are hurting bisectability if they don't happen together. Other than that, I think the intent of the change and the implementation look fine. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html