Re: [StGit PATCH 5/9] Convert 'hide' to the lib infrastructure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2009/4/29 Karl Hasselström <kha@xxxxxxxxxxx>:
> On 2009-04-28 16:10:03 +0100, Catalin Marinas wrote:
>
>> -args = [argparse.patch_range(argparse.applied_patches,
>> -                             argparse.unapplied_patches)]
>> +args = [argparse.patch_range(argparse.unapplied_patches)]
>
> Why not simply allow all patches? reorder_patches() below will happily
> pop unapplied patches before hiding them IIRC, and for already hidden
> patches you could just say "already hidden".
>
> Hmm, but this is for the tab completion, so I guess we'd only want the
> applied and unapplied patches here.

I fixed that in the proposed branch but I was to slow on sending e-mails.

> As I said,
>
>  * Why not simply allow hiding of applied patches?
>
>  * Hiding a hidden patch should probably be a warning (if that), not
>    an error.

Fixed this as well.

-- 
Catalin
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]