2009/5/13 Junio C Hamano <gitster@xxxxxxxxx>:
> Alex Riesen <raa.lkml@xxxxxxxxx> writes:
>
>> + for (i = 0; i < url_len; ++i)
>> + if ('\n' == url[i])
>> + fputs("\\n", fp);
>> + else
>> + fputc(url[i], fp);
>> + fputc('\n', fp);
>
> This ad-hoc quoting feels _very_ wrong. Who is on the reading side and
> how does it unquote?
git fmt-merge-msg. It does not unquote. The url is purely informational here.
OTOH, the \n shouldn't be in url text at all, so treat it as slightly
less annoying
warning.
> If it is just informational use only, then it might make more sense to
> drop this ugly "quoted \n" silently. I dunno.
That'd mean to loose the information completely. Which is just as bad
as putting the LF in the url in the first place.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html