Hugo Mildenberger, Tue, May 12, 2009 18:59:58 +0200: > > > I looked into guess_dir_name(). > > > > That's not the right place. The place I meant is right below the call > > to this function (you have to parse the names given in the command-line > > too). > > > > The automatically generated (that's the case with guess_dir_name) > > directory name certainly shouldn't contain any unexpected characters. > > > > > A regex call would be easy to fit, but > > > currently the git binary does not depend on libpcre. Is it generally > > > considered to be acceptable to add such a dependency? > > > > No. And pcre is not the only regex lib in the world. And we prefer > > shell patterns, if any at all. > > You really want to use shell patterns to match against a string from within a binary? Is that a problem? Especially if the matching expression is just something like a character class? > Although git already makes use of regexec from glibc or compat/regex > directory in numerous places? You said pcre, and I wasn't able to look at the source at the time I answered your mail to check if git relies on POSIX regexp. I did (and remembered git grep), so no need for pcre and regular exceptions are just a line away. P.S. Could you please quote more appropriately? Your discussion is a little hard to follow. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html