Re: [JGIT PATCH] Fix data corruption in DirCacheIterator when EmptyTreeIterator is used

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Robin Rosenberg <robin.rosenberg.lists@xxxxxxxxxx> wrote:
> 
> Shouldn't we update some unit tests too? The dircache must be reliable.

I see you ignored the remark I put in the cover letter below the ---.

I think we should have unit tests too.  I just can't come up with
a way test the fix to prevent regression.  And I don't have any
more time for it probably the rest of this week.  I'd rather have
the corruption fix in the tree with no test than continue to have
surprising corruption under certain cases.  But if you or Mark can
offer a test, I'd love to have it.

-- 
Shawn.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]