Re: [PATCH 0/5] gitweb: Some code cleanups (up to perlcritic --stern)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jakub Narebski <jnareb@xxxxxxxxx> writes:

> On Mon, 11 May 2009, Junio C Hamano wrote:
>
>> But this series, when queued to 'pu', seems to break t9500; I haven't
>> looked at the breakage myself yet.
>
> I'm sorry about that. My bad. The fix is in the email (unless you
> prefer for me to just resend the series)...

That's Ok.  I had them near the tip of 'pu', and I can just replace them.

But this episode does not give much confidence in Perl::Critic does it?
The runtime "use strict" diagnosed undeclared globals in the cleaned up
code, but presumably the Critic did not complain anything about it, right?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]