Re: [PATCH v2] git-svn: add --authors-prog option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 8, 2009 at 3:43 AM, Michael J Gruber
<git@xxxxxxxxxxxxxxxxxxxx> wrote:
> Mark Lodato venit, vidit, dixit 08.05.2009 03:11:
>>  config key: svn.authorsfile
>>
>> +--authors-prog=<filename>::
>> +
>> +If this option is specified, for each SVN committer name that does not
>> +exist in the authors file, the given file is executed with the commiter
>
> s/commiter/committer/
>
> Also, "If..., the given... for each..." may be easier to read.
>
>> +name as the first argument.  The program is expected to return a single
>> +line of the form "Name <email>", which will be logically inserted into the
>
> "be treated as if included in the..."

Will do.

>
> Maybe we want a config key also, just like for the authors file.

Yes, this is a very good idea.  I will figure out how to do this.

> The feature itself looks useful for large user databases. For smaller
> ones one could just as well update the authors file before each fetch by
> dumping the whole db in there (or even conditionally on git svn fetch
> erroring out due to encountering an unknown name).

Right.  This feature will most likely be useful in corporate
environments.  In my case, it is not possible to dump the entire user
database to a file, so this patch is the only solution.  Another
possible use case is where SVN usernames are standardized, e.g. "jdoe"
-> "J Doe <jdoe@xxxxxxxxxxx>".  Also, using --authors-prog solves the
problem of keeping the authors file up-to-date, if users are regularly
added or deleted.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]