Re: [PATCH v3] To make GIT-VERSION-FILE, search for git more widely

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Matthias Andree schrieb:
> Am 08.05.2009, 02:05 Uhr, schrieb Junio C Hamano <gitster@xxxxxxxxx>:
>> Interesting.  I wonder if you need the change to the Makefile.
>>
>> As long as GIT-VERSION-GEN notices that you have a freshly built git
>> available (test -x) and uses it, falling back to whatever on the PATH, it
>> would not have to touch GIT-VERSION-FILE, no?
> 
> Hi Junio,
> 
> Makefile (+ GNU make) is the actual culprit and introduces this cycle,
> why do we want to leave Makefile - of all things - alone?

Because it is not necessary to change it?

With Junio's proposed change the following:

   $ make && PATH=/bin:/usr/bin make

builds only once[*], whereas previously it built twice.

[*] It still builds twice in git-gui, but I think that your original patch
wouldn't fix that, either.

-- Hannes
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]