On Thu, May 07, 2009 at 01:45:48AM +0300, Felipe Contreras wrote: > -extern const char *prettify_ref(const struct ref *ref); > +extern const char *prettify_refname(const char *refname); > +#define prettify_ref(ref) prettify_refname((ref)->name) I think it is an improvement for this function to take just the name, but I don't see much point in keeping the crufty #define compatibility. I would just fix up the few callers, as it really is just s/ref/ref->name/. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html