Re: [PATCH] Fix sloppy Getopt::Long.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



"Robin H. Johnson" <robbat2@xxxxxxxxxx> writes:

> Getopt-Long v2.38 is much stricter about sloppy getopt usage. The
> trailing pipe causes git-svn testcases to fail for all of the --stdin
> argument calls.

I am not objecting at all; just asking for clarification.

> -			{ 'stdin|' => \$_stdin, %cmt_opts, %fc_opts, } ],
> +			{ 'stdin' => \$_stdin, %cmt_opts, %fc_opts, } ],

Is this "pipe" supposed to be followed by an alternative spelling of the
option, as in

	'stdin|standard-input' => \$_stdin, ...

and is the sloppyness that it would be crazy to accept either --stdin or
just -- (without actual option name) for this option?

Could an older version of Getopt::Long() have accepted

	$ command --foo --bar - other args

to set $_stdin to true with that "sloppy" syntax?  If so people could have
relied on such a behaviour, which is a bit worrying.

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]