On Tue, 5 May 2009, Kana Natsuno wrote:
> On Tue, 05 May 2009 23:03:49 +0900, Jakub Narebski <jnareb@xxxxxxxxx> wrote:
> > I don't know if it is a bug or a feature, but git-config supports
> > quoted strings (required if you want to have value which has trailing
> > or leading whitespace, or which contains '#' which is beginning of
> > comment character). Inside quoted string you need to escape '"':
Errr... what I meant here is that I don't know whether stripping
quotes inside value which is not quoted (does not begin and end in '"')
is intended or unintended consequence of git-config behaviour.
> >
> > [string]
> > quotes = "quoted \" string ' with # character"
> >
> > expands as intended. Perhaps stripping of double quotes
> > inside string are artifact of that feature. Try escaping or
> > double escaping quotes: \" or \\\".
>
> Thank you for the information. I've read the source code of git
> and I confirmed that this stripping is caused by parse_value() in
> config.c.
>
>
> And as I changed the old definition
>
> lr = !$SHELL -c 'n=10; 1="${1:-$n}"; ...' __dummy__
>
> by enclosing all text in double quotes and substituting '"' with
> '\"' as follows,
>
> lr = "!$SHELL -c 'n=10; 1=\"${1:-$n}\"; ...' __dummy__"
>
> it works well now.
>
> $ git config --get alias.lr
> !$SHELL -c 'n=10; 1="${1:-$n}"; if ! [ "${1##[0-9]*}" ...
By the way, you can use continuation-of-line character (end line
with '\') and/or can embed newlines using C escape sequence, i.e. "\n".
So your code can look like this (although I am not sure it is worth it):
[alias]
lr = "!$SHELL -c ' \n\
n=10; \n\
1=\"${1:-$n}\"; \n\
if ! [ \"${1##[0-9]*}\" = \"\" ]; then \n\
t=\"$1\"; \n\
1=\"${2:-$n}\"; \n\
2=\"$t\"; \n\
fi; \n\
git --no-pager l1 --reverse -\"$1\" \"${2:-HEAD}\" \n\
' __dummy__"
BTW. you need to quote value because it contains comment character '#'
in 4th line of script.
--
Jakub Narebski
Poland
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html