Junio C Hamano <gitster@xxxxxxxxx>:
> Frank Terbeck <ft@xxxxxxxxxxxxxxxxxxx> writes:
>
> > If set to true, format-patch behaves like it had been started
> > using the --cover-letter option.
>
> I thought "If this is set, you can run format-patch without giving an
> explicit --cover-letter=foo from the command line" was already done with
> the earlier format.coverletter configuration variable. Why do you need a
> separate variable? It does not make any sense to me, unless I am missing
> something.
Well, the two can certainly by merged. That could potentially break
people's existing scripts - either by new default behaviour or by the
setting of format.coverletter of an individual user. That could still
happen when using coverauto, so maybe my reasoning was flawed - given
that Stephen raised the same question.
So, I should create one option 'coverletter'. If it's set to zero,
never create cover letters; if one, always create cover letters; if
any other positive integer, create cover letters automatically if a
patch series is at least that long. And do that without requiring the
user to supply --cover-letter; only provide that option to explicitly
overwrite the configured behaviour. Right?
If so, do you want coverletter to default to zero (which wouldn't
change the default behaviour) or do you want it to default to two?
Regards, Frank
--
In protocol design, perfection has been reached not when there is
nothing left to add, but when there is nothing left to take away.
-- RFC 1925
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html