On Mon, May 4, 2009 at 2:59 AM, Frank Terbeck <ft@xxxxxxxxxxxxxxxxxxx> wrote:
> An exception is if it is called using the --stdout option,
> which disables format.coverauto, because users of --stdout
> (like git-rebase.sh) usually are not interested in
> cover letters at all.
>
Would it make more sense to just have git-rebase.sh use
--cover-letter=never? I thought configuration variables were defaults
which have to be overridden.
Also, why does this variable even exist? I think Jeff's suggestion is
best, where you can set format.coverletter to always, never, or some
number.
> + if (!strcmp(var, "format.coverauto")) {
> + cover_letter = git_config_bool(var, value);;
> + return 0;
> + }
Double semi-colon?
Finally, this option is very useful, so keep up the good work.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html