On Wednesday 29 April 2009 09:49:41 Holger Weiß wrote: > * Holger Weiß <holger@xxxxxxxxxxxxxxxxxx> [2009-04-29 15:42]: > > The description of the "--prefix" option suggested that a slash would > > automatically be appended to the specified <prefix>, which is not the > > case. > > Nonsense, it's telling the user that appending a slash to the <prefix> > is mandatory. Scratch my patch. I just tried not using a slash; it doesn't give an error or internally add one, instead it makes a worthless archive: $ git archive --prefix=noslash HEAD | tar tv | head -rw-rw-r-- root/root 51 2009-04-28 01:46 noslash.gitattributes -rw-rw-r-- root/root 2416 2009-04-28 01:46 noslash.gitignore -rw-rw-r-- root/root 2519 2009-04-28 01:46 noslash.mailmap -rw-rw-r-- root/root 18787 2009-04-28 01:46 noslashCOPYING drwxrwxr-x root/root 0 2009-04-28 01:46 noslashDocumentation/ -rw-rw-r-- root/root 17 2009-04-28 01:46 noslashDocumentation/.gitattributes -rw-rw-r-- root/root 91 2009-04-28 01:46 noslashDocumentation/.gitignore -rw-rw-r-- root/root 4868 2009-04-28 01:46 noslashDocumentation/CodingGuidelines -rw-rw-r-- root/root 9028 2009-04-28 01:46 noslashDocumentation/Makefile -rw-rw-r-- root/root 1255 2009-04-28 01:46 noslashDocumentation/RelNotes-1.5.0.1.txt Should this be fixed by automatically adding a slash if there wasn't one given? I can't image anyone would want an archive made of mangled filenames like this, so if we don't want that behavior, it seems like it should at least give an error. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html