From: Matthias Sohn <matthias.sohn@xxxxxxx>
The equals(Object o) method shouldn't make any assumptions about the
type of o. It should simply return false if o is not the same type as
this.
Signed-off-by: Matthias Sohn <matthias.sohn@xxxxxxx>
---
Shawn Pearce <spearce@xxxxxxxxxxx> wrote:
> FWIW, your From header in the emails comes out "Sohn, Matthias"
> while your Signed-off-By is as above. This means that when I slam
> your patch through git-am I get an author name of "Sohn, Matthias",
> which looks damn funny. I have to remember to edit the patch after
> the fact to make it come out correct.
>
> Any change you can get your MUA to behave better? Or is this
> Exchange enforcing a nice uniform standard... *sigh*
Didn't find a way to get around our Exchange server mangling the from header,
hence trying to give From: in mail body. If this doesn't help I will issue a
ticket for our Exchange administration to get this solved.
.../src/org/spearce/jgit/lib/AnyObjectId.java | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/AnyObjectId.java b/org.spearce.jgit/src/org/spearce/jgit/lib/AnyObjectId.java
index 2e3a43e..acb3cb5 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/lib/AnyObjectId.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/lib/AnyObjectId.java
@@ -253,7 +253,10 @@ public boolean equals(final AnyObjectId other) {
}
public boolean equals(final Object o) {
- return equals((AnyObjectId) o);
+ if (o instanceof AnyObjectId)
+ return equals((AnyObjectId) o);
+ else
+ return false;
}
/**
--
1.6.2.2.1669.g7eaf8
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html