Bill Pemberton <wfp5p@xxxxxxxxxxxx> writes: > The following are some code cleanups for git-send-email.perl. They're > based on suggestions by perlcritc. > > Bill Pemberton (6): > Remove return undef from validate_patch > Remove function prototypes from git-send-email.perl > Remove return undef from ask() > Add explict return to end of subroutines > Remove mix of high and low-precedence booleans > Remove bareword filehandles in git-send-email.perl Perl styles are highly personal. While I admit that the changes these patches bring in match my personal taste more or less exactly [*1*], there was somebody (sorry I lost track) who volunteered to take the maintenance responsibility of that program over to clean up or even rewrite it, so I would rather have that person have a say in the overall styles of the (rewritten) program. [Footnote] *1* ...except for the "and/or vs &&/||" bits, even though I prefer the latter myself solely because I am old fashioned. I think it is simply silly to say "precedence of ! and and/or does not mix". "!" and "&&" have different precedence and rewriting (A and !B) into (A && !B) would not make things any better nor worse. After all, nobody would have problems with "$a + $b * $c" even though + and * have different precedence. Oh, I also do not agree with "always explicitly return". If the change and explanation were limited to the subs whose return values are _used_, I would agree with the change, though. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html