2006/9/8, Rene Scharfe <rene.scharfe@xxxxxxxxxxxxxx>:
Franck Bui-Huu schrieb:
> From: Rene Scharfe <rene.scharfe@xxxxxxxxxxxxxx>
>
> Signed-off-by: Rene Scharfe <rene.scharfe@xxxxxxxxxxxxxx>
> Signed-off-by: Franck Bui-Huu <vagabon.xyz@xxxxxxxxx>
I did not sign off this exact patch. I wrote and submitted the
builtin-tar-tree.c part, with memory leak and all, then sent a note
on where the leak needs to be plugged. You put it together and
converted it to struct archiver_args. I'd very much have liked to
see a comment stating this. Or simply just say "based on code by
Rene" or something. The same is true for patch 3/4.
OK I'll change that....
> ---
> extern void parse_pathspec_arg(const char **pathspec,
> struct archiver_args *args);
> +/*
> + *
> + */
Especially I would not have signed off this invisible comment. ;)
René
and put something usefull here.
Thanks
--
Franck
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html