Michael J Gruber <git@xxxxxxxxxxxxxxxxxxxx> writes: > Michael S. Tsirkin venit, vidit, dixit 28.04.2009 14:30: >> This adds --reference option to git submodule add and >> git submodule update commands, which is passed on to git clone. >> >> Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx> >> --- >> >> Here's v2. Ack? > > I don't think it's up to me to Ack but you addressed my remarks. You can certainly say "Reviewed-by: me" and/or "Tested-by: me". > BTW, even dash has "test STRING" so portability doesn't require -n but I > think it's OK either way. It always is a good discipline and style. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html