Hi, On Fri, 24 Apr 2009, Andy Lester wrote: > On Apr 24, 2009, at 7:07 PM, Johannes Schindelin wrote: > > >I dunno. The most important part of CodingGuidelines is this: > > > > As for more concrete guidelines, just imitate the existing code > > (this is a good guideline, no matter which project you are > > contributing to). > > > >(And of course, this holds for the style of commit messages, too.) > > > Would you rather I not bother? Far be it from me to try to force myself on > any project. Sorry, Andy, I forgot to add the Disclaimer: if you are offended by constructive criticism, or likely to answer with insults to the comments I offer, please stop reading this mail now (and please do not answer my mail, either). :-) Still with me? Good. Nice to meet you. Just for the record: responding to a patch is my strongest way of saying that I appreciate your work. The thing with SubmittingPatches is: I think it is already too long for people to quickly read and get stuff done. But hey, I was wrong before, and I will be wrong again. That's why I offered my opinion, and I _can_ be convinced of another opinion. Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html