Alex Riesen, Thu, Apr 23, 2009 20:57:32 +0200: > Junio C Hamano, Thu, Apr 23, 2009 16:51:28 +0200: > > For example, I do not think conversion from Perl exec() to Perl system() > > is worsening the code in any way in difftool. Sure, it won't *improve* > > things for general majority of people, but as long as it does not hurt > > people (that includes me and others who pay maintenance cost), I do not > > think we should just bury the patch in archive or in your laptop. > > Isn't it clearly marked in the archives with the keywords most often > associated with the platform? (they may seem a little... unprintable) > > Still, you are, as usual, right. Especially regarding this particular case. > > I'll add this comment regarding use of system in the case where exec > is right choice on all accounts and resend the patch: > > # ActiveState Perl for Win32 does not implement POSIX semantics of > # exec* system call. It just spawns the given executable and finishes > # the starting program, exiting with code 0. > # system will at least catch the errors in returned by git diff, > # allowing the caller of git difftool better handling of failures. Oh... I'm too late... -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html