Re: [PATCH] tests: remove xargs in favor of --stdin where possible

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Nguyễn Thái Ngọc Duy  <pclouds@xxxxxxxxx> writes:

> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx>
> ---
>  Patch "Convert to use quiet option when available" reminds me I had a similar
>  patch to remove (mostly) xargs usage from tests.

The reason being...?

 (1) xargs is not universally available, or portable enough?

 (2) people may learn from tests, and we should demostrate our ability?

 (3) something else?

If the reason is (1) I would understand it, but if it is (2) then I am a
bit reluctant.  

The tests may not break with your change because none of them may use
problematic characters (especially "\n" and '"'), but update-index --stdin
without -z is not suitable for reading from output from "find" without -0
option (on the other hand, "update-index -z --stdin" is good for reading
output from "find -0"; but for portability we avoid GNUism "find -0").

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]