On Fri, Sep 08, 2006 at 01:49:20AM -0700, Junio C Hamano wrote:
> > + if (trail)
> > + r += printf("%s", trail);
> > + if (*color)
> > + r += printf("%s", COLOR_RESET);
> > + return r;
> > +}
> Hmm,... don't you mean RESET first and then trail (which is often "\n")?
ARGH. Yes, sorry about that. I wrote it correctly once, and then
refactored it to be wrong. :)
> Please spell NULL not 0 (please do not argue that writing a NULL
Sorry, I should clearly go read the linux CodingStyle doc before
subjecting you to any more of my patches.
I'm assuming you can mark both of those up yourself rather than having
me resend?
-Peff
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html