Re: [PATCH] show-branch: color the commit status signs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 21, 2009, Markus Heidelberg <markus.heidelberg@xxxxxx> wrote:
> +--color::
> +       Color the status sign of the commits. Each branch uses a single color.

I don't know what the status sign of a commit is without reading your commit
message. Maybe reword this to be:

Color the status sign ('*' '!' '+' '-') of each commit corresponding
to the branch
it's in.

> +static char column_colors[][COLOR_MAXLEN] = {
> +       GIT_COLOR_RED,
> +       GIT_COLOR_GREEN,
> +       GIT_COLOR_YELLOW,
> +       GIT_COLOR_BLUE,
> +       GIT_COLOR_MAGENTA,
> +       GIT_COLOR_CYAN,
> +};
> +
> +#define COLUMN_COLORS_MAX (ARRAY_SIZE(column_colors))

This looks like a copy/paste (with a small edit) from graph.c so maybe you
want to refactor the original code from graph.c to color.h?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]