Re: [RFC/PATCH v2] graph API: Use horizontal lines for more compact graphs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

> Everything else look good?

No objection from my side.

> Actually now that I look at it, it might be a good idea to put an assert
> statement in that for loop like `assert(graph->new_mapping[j] < 0)' to
> make sure we don't clobber any existing lines.  But that seems like
> overkill since we're already assured to be the first collapsing edge at
> that point, which would imply that all previous odd indeces are empty.
> WDYT?

Yep, sounds like overkill to me, too.

Thanks!
Dscho
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]