Robin Rosenberg <robin.rosenberg@xxxxxxxxxx> wrote: > .../src/org/spearce/jgit/lib/Repository.java | 76 ++++++++++++++++---- > 1 files changed, 63 insertions(+), 13 deletions(-) NAK. I see a number of things I don't like about this implementation as it stands. I'll try to work up a counter patch today. At a glance, the new logic for openObject is pretty twisted to follow. It mostly makes sense, but I had hoped for something cleaner to read. I'm really worried about the case where a pack file stays with the same name, but its contents and index have been recreated, and thus our existing PackFile object is invalid for access to it. Your implementation as written would keep the same PackFile in memory, and we'd lose access to those objects. You also pointed out some concerns about windows stuck in the WindowCache. I'm equally worried about that. -- Shawn. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html