On Sun, Apr 19, 2009 at 10:50 PM, Robin Rosenberg <robin.rosenberg.lists@xxxxxxxxxx> wrote: > > First, Ferry Huberts is also working on a solution for ignore See > http://thread.gmane.org/gmane.comp.version-control.git/114825 though you > focus on different aspects. Yup, saw the issue 32. I'll keep an eye on that and hopefully I can leverage what that does when it's ready. > This patch is whitespace damaged. Pasting into gmail won't work. Gmail > has authenticated SMTP on port 25 and 465 (SSL) so git-send-email should work that way. One advantage of attaching issues is you don't have MUA problems :-) I'll try and get a patch to work via git-send-email later. >> + private static final String GITIGNORE_ENCODING = "UTF-8"; > > For the time being we use Constants.CHARACTER_ENCODING Great, thought there'd be something already. Will use that. >> + NullProgressMonitor m = new NullProgressMonitor(); > I guess this method should execute fairly fast, but in general we should run > with a real progress monitor. See an action, like Track (maybe we should > rename to TrackAction...). OK, will put in a real one. > I think this series should be one patch only. I've been incrementally committing to my local git copy. Whenever I do git format-patch <since> it spews out individual patchettes. How can I use git to generate one patch? I could git diff <since>, but that's not following the SUBMITTING_PATCHES, is it? > Some actual error logging would be nice. Activator.logError for just logging and MessageDialog.openError > for posting an error message to the user. Righto, next on the list. Alex -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html