Nanako Shiraishi wrote: > Quoting Christian Couder <chriscool@xxxxxxxxxxxxx>: > >> There are downsides to this patch. First it is big. And "revs" is >> initialized once when doing "memset(&info, 0, sizeof(info))" and >> once in "init_revisions". > > I'm sorry if it is obvious, but is there any upsides? As the patch shows, the lifetime of the revs is the same as that of info (i.e., there are never memcpys from something into revs). Paolo -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html