On Fri, Apr 17, 2009 at 04:48:59PM -0700, Tommi Virtanen wrote: > On Fri, Apr 17, 2009 at 04:40:54PM -0700, Junio C Hamano wrote: > > How does this interact with a typical gitosis installation? I think it > > extracts bits from the ORIGINAL_COMMAND and formulates a sanitized command > > line and then passes it to git-shell but I do not think it removes the > > variable from the environment. > > Yup, not sanitizing. I could make that change easily, if you want, but > there's plenty of installations out there already. > > I'd say add a git-shell flag that enables any magic behavior, don't > just magically work differently based on that environment variable. > Sometimes that is set for reasons that are not related to what you're > actually running in the end; e.g. "chroot /foo exec-whatever-i-gave-you". What about triggering only when there is no option at all? Doing so would normally terminate git-shell telling the user it's not a shell. Mike -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html