If there is a commit that ends in ^X and is longer in length than what will fit in title_short, then it doesn't get fed through esc_html() and so the ^X will appear as-is in the page source. When Firefox comes across this, it will fail to display the page, and only display a couple lines of error messages that read like: XML Parsing Error: not well-formed Location: http://git .... Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> --- gitweb/gitweb.perl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 33ef190..e686e82 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -2470,7 +2470,7 @@ sub parse_commit_text { foreach my $title (@commit_lines) { $title =~ s/^ //; if ($title ne "") { - $co{'title'} = chop_str($title, 80, 5); + $co{'title'} = chop_and_escape_str($title, 80, 5); # remove leading stuff of merges to make the interesting part visible if (length($title) > 50) { $title =~ s/^Automatic //; -- 1.6.2.3 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html