Constantine Plotnikov <constantine.plotnikov@xxxxxxxxx> wrote:
> The part of DefaultSshSessionFactory that does not depend on
> AWT was refactored to the super class SshConfigSessionFactory.
> The parts of DefaultSshSessionFactory that were used only by
> the OpenSshConfig class were moved to that class.
>
> Signed-off-by: Constantine Plotnikov <constantine.plotnikov@xxxxxxxxx>
Thanks. I applied this, but with a couple of style nitpicks corrected.
> --- a/org.spearce.jgit/src/org/spearce/jgit/transport/OpenSshConfig.java
> +++ b/org.spearce.jgit/src/org/spearce/jgit/transport/OpenSshConfig.java
> @@ -95,6 +97,9 @@ public static OpenSshConfig get() {
> /** Cached entries read out of the configuration file. */
> private Map<String, Host> hosts;
>
> + /** IANA assigned port number for SSH. */
> + static final int SSH_PORT = 22;
> +
Static constants should be at the top of the class, not after the
instance members.
--
Shawn.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html