On Wed, Apr 15, 2009 at 10:17:36PM -0700, Junio C Hamano wrote:
> > + /* tar-tree defaults to fix-attributes as before */
> > + nargv[nargc++] = "--fix-attributes";
> > +
> > switch (argc) {
> > default:
> > usage(tar_tree_usage);
>
> I screwed up this part; nargv[] array needs to be enlarged by one element
> because of this change. It resulted in a funny breakage in tests that
> triggered only when run from the toplevel of the tree but did not surface
> when the individual test was done from t/ directory, which my final
> testing on the k.org machine caught, and that is why I still haven't
> managed to push the result out for tonight.
FWIW, running t5000 with --valgrind does catch it. I'll try to run the
full test suite with valgrind on the last -rc before 1.6.3 to catch any
hidden issues which have cropped up during this cycle (I can do it
earlier, too, but it is a real pain to run the whole thing, so I want to
just wait until the last minute).
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html