On Wed, Apr 15, 2009 at 8:40 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Holger Weiß <holger@xxxxxxxxxxxxxxxxxx> writes: > >> Fix the detection of the requested snapshot format, which failed for >> PATH_INFO URLs since the references to the hashes which describe the >> supported snapshot formats weren't dereferenced appropriately. >> >> Signed-off-by: Holger Weiß <holger@xxxxxxxxxxxxxxxxxx> >> --- >> I guess this one got lost. Without this patch, snapshots won't work if >> Gitweb is configured to generate PATH_INFO URLs. (Original Message-ID: >> <20090331161636.GV30233737@xxxxxxxxxxxxxxxx>). > > The patch looks obviously correct; "our %known_snapshort_formats" maps a > name to a hashref, but the current code makes a nonsense assignment, > essentialy doing ($fmt, %opt) = ($name, $hashref), but what would I > know... I am not using gitweb actively. My gitweb over at http://git.oblomov.eu/ supports snapshots with PATH_INFO just fine even without the need for this patch. Could this be a perl version issue? My apache is using mod_perl version 2.0.4, and I have a perl 5.10 on my system. -- Giuseppe "Oblomov" Bilotta -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html