Dan McGee <dpmcgee@xxxxxxxxx> writes:
> Signed-off-by: Dan McGee <dpmcgee@xxxxxxxxx>
Empty log message?
I am scratching my head because this came as a reply to:
...
> This I have absolutely no issue with.
>
> Acked-by: Nicolas Pitre <nico@xxxxxxx>
I do not have problem with the wording either, but then the commit log
message needs to change, I think. Care to re-submit?
and your original read quite nicely:
Subject: [PATCH 2/2] pack-objects: report actual number of threads to be used
Date: Sat, 4 Apr 2009 11:59:56 -0500
Message-ID: <1238864396-8964-2-git-send-email-dpmcgee@xxxxxxxxx>
In the case of a small repository, pack-objects is smart enough to not start
more threads than necessary. However, the output to the user always reports
the value of the pack.threads configuration and not the real number of
threads to be used. This is easily fixed by moving the printing of the
message after we have partitioned our work.
(pack.threads is on autodetect and would be set to 4)
$ git-repack -a -d -f
Counting objects: 55, done.
Delta compression using 2 threads.
Compressing objects: 100% (48/48), done.
Writing objects: 100% (55/55), done.
Total 55 (delta 10), reused 0 (delta 0)
Signed-off-by: Dan McGee <dpmcgee@xxxxxxxxx>
I was expecting to see something with a similar structure. An updated
title, an introductory text and the problem description, and the
description of the solution. Then "Acked-by:" you already received.
The new title looks correct, the problem description from the original
should still apply, but the solution is different, and that needs to
change.
I've committed it like this:
Author: Dan McGee <dpmcgee@xxxxxxxxx>
Date: Thu Apr 9 10:45:39 2009 -0500
Update delta compression message to be less misleading
In the case of a small repository, pack-objects is smart enough to not
start more threads than necessary. However, the output to the user always
reports the value of the pack.threads configuration and not the real
number of threads to be used.
Signed-off-by: Dan McGee <dpmcgee@xxxxxxxxx>
Acked-by: Nicolas Pitre <nico@xxxxxxx>
Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx>
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html