Re: [PATCH] bisect: avoid pipes to better catch "git rev-list" errors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Nanako Shiraishi <nanako3@xxxxxxxxxxx> writes:

> Quoting Christian Couder:
>
>> When doing:
>> 
>> eval "git rev-list --bisect-vars ..." | {
>>         while read line
>>         do
>>                 echo "$line &&"
>>         done
>>         echo ':'
>> }
>> 
>> the result code comes from the last "echo ':'", not from running
>> "git rev-list --bisect-vars ...".
>> 
>> This means that we may miss errors from "git rev-list".
>> 
>> To fix that, this patch gets rid of the pipes by redirecting the
>> output of "git rev-list" into a file, and then reading from this
>> file.
>> 
>> Signed-off-by: Christian Couder <chriscool@xxxxxxxxxxxxx>
>
> Junio, may I ask what happened to this patch?

I've chosen to ignore it, hoping that Christian's other bisect topic to
stabilize soon.  That will make this patch unnecessary, I think.

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]