Re: [PATCH] Add "list" and "rm" sub commands to tg-depend

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 9 Apr 2009 19:34:06 +0200
Bert Wesarg <bert.wesarg@xxxxxxxxxxxxxx> wrote:

> 2009/4/9 Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>:
> > Hello Ira,
> >
> > On Wed, Apr 08, 2009 at 09:19:49AM -0700, Ira Weiny wrote:
> >> On Wed, 8 Apr 2009 10:39:55 +0200
> >> Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> wrote:
> >>

[snip]

> >> > > > +       mv $TMPFILE $root_dir/.topdeps
> >> > > > +else
> >> > > > +       echo "$name" >>"$root_dir/.topdeps"
> >> > > > +fi
> >> > > > +
> >> > > > +## commit it and update this branch
> >> > > >  git add -f "$root_dir/.topdeps"
> >> > > >  git commit -m"New TopGit dependency: $name"
> >> > > >  $tg update
> >> > > > --
> >> > > > 1.5.4.5
> >> > I don't think the patch is correct.  Just removing a branch from
> >> > .topdeps is not enough.
> >> >
> >> > Did you try to export the tg-branch?  The result will be that the patch
> >> > for that you deleted the dependency has the deleted change folded in.
> >>
> >> Indeed you are correct.  It was working for me because I was moving a node
> >> from one place to another.  But the new location was still an ancestor of the
> >> dependency which was removed.  I still think this can be automated but I will
> >> have to work on it.
> > So you mean that rm should only work if the patch is still a dependency?
> >
> > You might want to check
> >
> >        http:// thread.gmane.org/gmane.comp.version-control.git/114581
> >
> > before investing time to implement it.  (I cc:d Bert Wesarg.)  If you
> > had posted to git@xxxxxxxxxxxxxxx Bert might have seen your mail alone.
> > (hint hint)
> Uwe,
> 
> thanks for the Cc.
> 
> I really can't reconstruct this thread, could some one send me the
> original patch.

I have attached the original patch (cleaned up with Uwe's original comments).

NOTE: this will not work but I am just sending it to help reconstruct the
thread.

I think to do this properly you would have to either A) create a new branch
without the topic specified B) work your way back through the dependencies and
reverse patch all those nodes which do not have a common ancestor with any of
your other dependencies.  As an aside I found that topgit does not like you
removing the only dependency left.  I was unable to get that to work at all.
I don't know why.

I believe you specified option A in a message after this one, correct?

Ira

>
> My interest is this, that I implemented a tg-prev
> (lists all deps from given topic), tg-next (lists topics depending on
> the given topic), and a tg-tsort (which gives a topological list of
> dependencies, which is a little outdated after the --graphviz option)
> 
> The original message seems lost in the archive, the comments are still there:
> 
> http:// thread.gmane.org/gmane.comp.version-control.git/96483
> 
> I can send an update on this.
> 
> I think the first two commands could be added as sub-commands to
> tg-depend, with bash completion you don't need to type that much
> nowadays.
> 
> As I said to tg-tsort, its probably outdated because of the graphviz
> output, but may still provide valid information.  Btw. does anyone
> know a console output driver for the graphviz tools, i.e. dot and co?
> 
> Bert
> 
> >
> > Best regards
> > Uwe
> 
> PS: Finally added git list to Cc:
> 


-- 
Ira Weiny
Math Programmer/Computer Scientist
Lawrence Livermore National Lab
weiny2@xxxxxxxx

Attachment: 0001-Add-list-and-rm-sub-commands-to-tg-depend.patch
Description: Binary data


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]