Re: [PATCH] graph API: Added logic for colored edges

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2009-04-07 14:57 (-0400), Allan Caffee wrote:

> Modified the graph drawing logic to colorize edges based on
> parent-child relationships similiarly to gitk.

I like the colored graph very much, thanks. Unfortunately there are some
problems with aligning of log messages and headers. For example, try
this in git.git repository:


$ git log -1 --graph 796b137

*   commit 796b13781aecce551b8f92049a66646e60f31dce
|\ Merge: 6da14ee db12d97
| | Author: Junio C Hamano <gitster@xxxxxxxxx>
| | Date:   2009-04-08 23:41:27 -0700


Without colors or without your patch the alignment is correct:

$ git log -1 --graph --no-color 796b137

*   commit 796b13781aecce551b8f92049a66646e60f31dce
|\  Merge: 6da14ee db12d97
| | Author: Junio C Hamano <gitster@xxxxxxxxx>
| | Date:   2009-04-08 23:41:27 -0700


(Perhaps the "Merge:" header could have two spaces befor the data, but
this is  unrelated to --graph.)
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]