Re: [PATCH 1/2] Clarify the gitmodules and submodules docs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I think the new description is good, and the message claims to be sent by
send-email, but I am seeing a funny whitespace damage everywhere in your
patch.

 * Signed-off-by: and the three-dash lines have a leading SP

 * The first line of diffstat is indented by one SP as expected; the
   second line has one extra SP at the beginning.

 * everything after that has one extra SP at the beginning.  Also the hunk
   header for the first hunk is linewrapped.

Very curious.  I could just hand munge the patch if I wanted to, but I'd
rather not.  As you are in "GSoC preparation", I expect to receive
patches, perhaps tons of them, from you in the future, and I'd want to see
easier procedural wrinkles straightened out first.  That will allow us to
concentrate on the substance when "the real thing" starts.

    Added some explanation to the docs to clear up some confusing parts of
    git-submodules that appeared frequently on the mailing list.

We tend to say "Add some explanation..." here.  Think of it as your giving
an order to _me_, "cause this to happen", by accepting and applying your
patch.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]