Re: [PATCH 1/3] git remote update: Report error for non-existing groups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Finn Arne Gangstad <finnag@xxxxxxx> writes:

> @@ -1227,8 +1229,11 @@ static int update(int argc, const char **argv)
>  
>  	remote_group.list = &list;
>  	for (i = 1; i < argc; i++) {
> +		int groups_found = 0;
>  		remote_group.name = argv[i];
> -		result = git_config(get_remote_group, NULL);
> +		result = git_config(get_remote_group, &groups_found);
> +		if (!groups_found && (i != 1 || strcmp(argv[1], "default")))
> +			die("No such remote group: '%s'", argv[i]);

I think you are trying to be silent about the case where the caller feeds
you the default_argv[] array with this, but do we want to be more explicit
about this so that we do die when the end user explicitly says "default"
from the command line?

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]