Linus Torvalds <torvalds@xxxxxxxx> writes: > On Fri, 1 Sep 2006, Junio C Hamano wrote: >> >> [...] Instead make sure they are not corrupt, but >> do so only when we are not streaming to stdout, [...] > > Hmm. I see you making pack_to_stdout available to those functions, but I > don't actually see you using it - looks like you revalidate regardless. > > Which is safe, of course, but it doesn't match your description ;) But "git repack -a -d", which you now consider almost being free, in the recent kernel repository counts 300k objects, and reuses 298k objects or so. That means we expand and recompress that many objects, totalling 120MB. It might be worthwhile to disable revalidate reused objects individually and instead scan and checksum the entire .pack file when the number of objects being reused exceeds certain threshold, relative to the number of objects in existing pack, perhaps. -- VGER BF report: U 0.5 - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html