Junio C Hamano wrote: > Jakub Narebski <jnareb@xxxxxxxxx> writes: > >> At the below URL (links of course _won't_ work) >> http://front.fuw.edu.pl/jnareb/tree_blame.html >> is output of "tree_blame" view. One can sort by Date (age), Author, Mode >> and Filename. The date view was modelled after 'ls -l' view; the order of >> columns probably should be changed to match it more closely. > > Just a quick impression. > > - "Mode" looks too wide for the information it conveys. Path > being a link already tells whether it is a tree, so the only > information you would need is a bit and half (regular file, > executable regular file, or symbolic link). > > - Spelling out Date in human readable form is fine but I suspect > it would be nicer if it used YYYY-MM-DD / MM-DD HH:MM Good idea. > - I personally do not like blaming the last person who touched > the file, but that is probably just me so it is fine. I was going for something similar to the 'ls -l' look, with symbolic mode, user ("blame" i.e. last person who touched the file for gitweb), date in 'ls -l' format but in UTC and in C locale, file name. Preceded by commit, followed by related links (tree/blob, blame, history, raw). > - "Commit" column does not seem to convey much useful > information; I would suggest perhaps making Date and/or > Author clickable to take the browser to the commit, but I do > not understand what the strike-through is about... Ooops, I forgot to explain this. Strike-through, which actually should be using different color like red for example means that the file has 1-commit long history, i.e. it just appeared in given commit. BTW. commit link should show commit title on mouseover. > - Since the rightmost links have quite a lot of information > these days, it _might_ be reasonable to make the main part > 2 lines, like so: > > date author mode path > short-commit-log-message > > date author mode path > short-commit-log-message > > ... I'd rather have 1 line per entry, especially considering that one of key features is ability to sort the "tree_blame" table by date. > - I wonder how expensive it is to generate this. Quite expensive, especially for directories (trees) containing larger number of files, but if I remember correctly not much longer than for example summary or tags page. Speed is constrained by the forking, one per file/tree in given directory, at least for now. There are three implementations in git_tree_blame... Of course the engine should be rewritten in C, made into git-blame-tree (similar to git-blame). -- Jakub Narebski Warsaw, Poland ShadeHawk on #git - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html