Shawn Pearce <spearce@xxxxxxxxxxx> wrote: > We may well have a general problem here with always compressing > tree deltas. It appears to be a minor dent in the space required > for a pack but its certainly a non-trivial amount on the larger > Mozilla pack. The wasted space is 2% of the Git pack and its 6.7% > of the Mozilla pack. Whoops. mugwump (Sam Vilain) just pointed out on #git that I didn't account for the 20 byte base when comparing the offset differences (claimed compressed size) and the uncompressed size. Nor did I account for the variable sized headers. I stated that 29 MiB of the Mozilla pack was wasted by 976712 tree deltas. Of that 29 MiB we know that 18.6 MiB must be the 20 byte base-SHA1 header. That leaves 10.4 MiB unaccounted for. But we also have the variable length header; lets say the average uncompressed length of a tree delta is 44 MiB/976712 so 47 bytes. That average length can be encoded in two header bytes, so that's another 1.8 MiB. Which leaves us with 8.6 MiB of wasted space. Which is clearly not the 29 MiB I previously stated. But we're still wasting a small amount of space over not compressing them. -- Shawn. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html